A better solution to fix incorrect axis data in Chord
#433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I missed checking where the
InputStream::input_axis_pair()function was used, got a bit worried that it might be widely used. However, upon investigation, it seems it’s just handling this way forChords—my bad! This made the solution more complex. So, I undid #432 (what I did earlier) and fixed up #430 again.Fixing this problem should mainly involve checking if all buttons declared in the
Chordare pressed. This simpler solution (compared to the unchanged) uses a for-loop that breaks out early. Perhaps it could potentially improve performance by avoiding redundant calculations to get the first dual axis data?